[fix][client] Fix memory leak in ClientCnx.newLookup when there's TooManyRequestsException #23971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested review from
merlimat,
Technoboy-,
nodece,
poorbarcode and
shibd
lhotari
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23971 +/- ##
============================================
+ Coverage 73.57% 74.22% +0.64%
+ Complexity 32624 32270 -354
============================================
Files 1877 1853 -24
Lines 139502 143821 +4319
Branches 15299 16337 +1038
============================================
+ Hits 102638 106748 +4110
+ Misses 28908 28684 -224
- Partials 7956 8389 +433
Flags with carried forward coverage won't be shown. Click here to find out more.
|
merlimat
approved these changes
Feb 12, 2025
merlimat
pushed a commit
that referenced
this pull request
Feb 12, 2025
…ManyRequestsException (#23971)
merlimat
pushed a commit
that referenced
this pull request
Feb 12, 2025
…ManyRequestsException (#23971)
merlimat
pushed a commit
that referenced
this pull request
Feb 12, 2025
…ManyRequestsException (#23971)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 19, 2025
…ManyRequestsException (apache#23971) (cherry picked from commit 9d767b3)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 20, 2025
…ManyRequestsException (apache#23971) (cherry picked from commit 6a61464)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There's a Netty ByteBuf leak in ClientCnx.newLookup when there's TooManyRequestsException.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete