[improve][admin] Opt-out of topic-existence check #23709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@omarkj Please add the following content to your PR description and select a checkbox: |
|
omarkj
changed the title
omarkj
changed the title
lhotari
reviewed
Dec 10, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
omarkj
force-pushed
the
topic-existence-check-opt-out
branch
from
5b0bd1a to
1deb48c
Compare
… would like to be able to set permissions to topics that have not yet been created, for instance if a topic is going to be created lazily at a later time.
omarkj
force-pushed
the
topic-existence-check-opt-out
branch
from
1deb48c to
2ff2a3c
Compare
|
Usually we require PIPs for changes for new configuration options. However in this case, this is addressing a breaking change that was introduced by PR #22547. That's why I think there's no need for a PIP. It would be great if PR #22547 could be documented afterwards by @Technoboy- since that PR was a breaking change and it would have required a PIP according to our criteria. |
4 tasks
dao-jun
added
doc-required
github-actions
bot
added
doc-label-missing
and removed
doc-not-needed
|
pls resolve the ci failures |
dao-jun
approved these changes
Dec 11, 2024
github-actions
bot
added
doc-not-needed
lhotari
reviewed
Dec 11, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23709 +/- ##
============================================
+ Coverage 73.57% 74.37% +0.80%
- Complexity 32624 35081 +2457
============================================
Files 1877 1945 +68
Lines 139502 147480 +7978
Branches 15299 16277 +978
============================================
+ Hits 102638 109691 +7053
- Misses 28908 29311 +403
- Partials 7956 8478 +522
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lhotari
pushed a commit
that referenced
this pull request
Dec 11, 2024
Co-authored-by: Ómar Yasin <[email protected]> Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit f571aa1)
lhotari
pushed a commit
that referenced
this pull request
Dec 11, 2024
Co-authored-by: Ómar Yasin <[email protected]> Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit f571aa1)
lhotari
pushed a commit
that referenced
this pull request
Dec 11, 2024
Co-authored-by: Ómar Yasin <[email protected]> Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit f571aa1)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 19, 2024
Co-authored-by: Ómar Yasin <[email protected]> Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit f571aa1) (cherry picked from commit ef57c2a)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 23, 2024
Co-authored-by: Ómar Yasin <[email protected]> Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit f571aa1) (cherry picked from commit ef57c2a)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 27, 2024
Co-authored-by: Ómar Yasin <[email protected]> Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit f571aa1) (cherry picked from commit ef57c2a)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 30, 2024
Co-authored-by: Ómar Yasin <[email protected]> Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit f571aa1) (cherry picked from commit ef57c2a)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
Co-authored-by: Ómar Yasin <[email protected]> Co-authored-by: Lari Hotari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases users would like to be able to set permissions to topics that have not yet been created, for instance if a topic is going to be created lazily at a later time.
This change introduces a new configuration property for the broker to allow changing to that behaviour.