-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] [broker] Add consumer name for subscription stats #23671
Merged
Technoboy-
merged 1 commit into
apache:master
from
hangc0276:chenhang/add_consumer_name_for_subscription_stats
Dec 4, 2024
Merged
[fix] [broker] Add consumer name for subscription stats #23671
Technoboy-
merged 1 commit into
apache:master
from
hangc0276:chenhang/add_consumer_name_for_subscription_stats
Dec 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horizonzy
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
liudezhi2098
approved these changes
Dec 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23671 +/- ##
============================================
+ Coverage 73.57% 74.37% +0.79%
- Complexity 32624 35034 +2410
============================================
Files 1877 1944 +67
Lines 139502 147332 +7830
Branches 15299 16258 +959
============================================
+ Hits 102638 109577 +6939
- Misses 28908 29291 +383
- Partials 7956 8464 +508
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lhotari
pushed a commit
that referenced
this pull request
Dec 6, 2024
(cherry picked from commit 59d4588)
lhotari
pushed a commit
that referenced
this pull request
Dec 6, 2024
(cherry picked from commit 59d4588)
lhotari
pushed a commit
that referenced
this pull request
Dec 6, 2024
(cherry picked from commit 59d4588)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.9
release/3.3.4
release/4.0.2
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
When getting topic stats, the consumer name is missing in each subscription's consumer information
With this change, the topic stats will show consumer name
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: