[improve][test] Reduce OneWayReplicatorUsingGlobalZKTest.testRemoveCluster execution time #23633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uster execution time
pdolif
approved these changes
Nov 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23633 +/- ##
============================================
+ Coverage 73.57% 74.36% +0.78%
- Complexity 32624 34481 +1857
============================================
Files 1877 1944 +67
Lines 139502 147186 +7684
Branches 15299 16239 +940
============================================
+ Hits 102638 109449 +6811
- Misses 28908 29289 +381
- Partials 7956 8448 +492
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
approved these changes
Nov 25, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 28, 2024
…uster execution time (apache#23633) (cherry picked from commit 2126d40) (cherry picked from commit 7687326)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 28, 2024
…uster execution time (apache#23633) (cherry picked from commit 2126d40) (cherry picked from commit 7687326)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 6, 2024
…uster execution time (apache#23633) (cherry picked from commit 2126d40) (cherry picked from commit 7687326)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…uster execution time (apache#23633)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
OneWayReplicatorUsingGlobalZKTest.testRemoveCluster was timing out in branch-3.3 and I had to improve the test in order to get the test passing in branch-3.3 before 3.3.3 release.
Modifications
ignoreExceptions()to AwaitilityDocumentation
docdoc-requireddoc-not-neededdoc-complete