[fix][test] Fix DeadLetterTopicTest.testDeadLetterTopicWithInitialSubscriptionAndMultiConsumers #23552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23552 +/- ##
============================================
+ Coverage 73.57% 74.27% +0.70%
- Complexity 32624 34316 +1692
============================================
Files 1877 1943 +66
Lines 139502 147050 +7548
Branches 15299 16209 +910
============================================
+ Hits 102638 109223 +6585
- Misses 28908 29386 +478
- Partials 7956 8441 +485
Flags with carried forward coverage won't be shown. Click here to find out more. |
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 20, 2024
…scriptionAndMultiConsumers (apache#23552) (cherry picked from commit c266db2) (cherry picked from commit 3b1f359)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 21, 2024
…scriptionAndMultiConsumers (apache#23552) (cherry picked from commit c266db2) (cherry picked from commit 3b1f359)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…scriptionAndMultiConsumers (apache#23552)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23542
Motivation
The original
receiverQueueSizewas 100, and the producer generated a total of 100 messages. It is possible that all messages were put into the dead letter queue by one consumer, resulting in assertion failure.Modifications
Reduce the size of the
receiverQueueSizeto ensure that every consumer processes the message.receiverQueueSize：100 -> 20Verifying this change
The last test was manually cancelled.
Documentation
docdoc-requireddoc-not-neededdoc-complete