[improve] [broker] Phase 1 of PIP-370 support disable create topics on remote cluster through replication #23169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorbarcode
changed the title
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java
Outdated
Show resolved
Hide resolved
codelipenghui
approved these changes
Aug 20, 2024
|
/pulsarbot run-failure-checks |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23169 +/- ##
============================================
+ Coverage 73.57% 74.58% +1.01%
- Complexity 32624 34211 +1587
============================================
Files 1877 1918 +41
Lines 139502 144657 +5155
Branches 15299 15813 +514
============================================
+ Hits 102638 107898 +5260
+ Misses 28908 28503 -405
- Partials 7956 8256 +300
Flags with carried forward coverage won't be shown. Click here to find out more.
|
guan46
approved these changes
Aug 22, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 28, 2024
…n remote cluster through replication (apache#23169) (cherry picked from commit 44f9860) (cherry picked from commit 9553c33)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 28, 2024
…n remote cluster through replication (apache#23169) (cherry picked from commit 44f9860) (cherry picked from commit 9553c33)
grssam
pushed a commit
to grssam/pulsar
that referenced
this pull request
Sep 4, 2024
…n remote cluster through replication (apache#23169)
15 tasks
|
@poorbarcode why did we cherry-picked PIP-370 changes to branch-3.0, but branch-3.3 was skipped? Asked that on the dev mailing list thread, https://lists.apache.org/thread/onvgpx4vr1184tzjl2ngxog674zgltgk . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
see also PIP-370: configurable remote topic creation in geo-replication
Modifications
Next PRs
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x