Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] Validate user paths in Functions utils #22833

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented Jun 3, 2024

Motivation

For Python & Go functions, validate that the filename provided does not look into a parent directory.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@merlimat merlimat added this to the 3.4.0 milestone Jun 3, 2024
@merlimat merlimat requested a review from nlu90 June 3, 2024 23:52
@merlimat merlimat self-assigned this Jun 3, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 3, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 40.74074% with 16 lines in your changes missing coverage. Please review.

Project coverage is 73.24%. Comparing base (bbc6224) to head (6164a8a).
Report is 334 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22833      +/-   ##
============================================
- Coverage     73.57%   73.24%   -0.33%     
- Complexity    32624    32652      +28     
============================================
  Files          1877     1889      +12     
  Lines        139502   141780    +2278     
  Branches      15299    15559     +260     
============================================
+ Hits         102638   103848    +1210     
- Misses        28908    29926    +1018     
- Partials       7956     8006      +50     
Flag Coverage Δ
inttests 27.44% <0.00%> (+2.86%) ⬆️
systests 24.85% <0.00%> (+0.53%) ⬆️
unittests 72.26% <40.74%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...org/apache/pulsar/broker/web/ExceptionHandler.java 100.00% <100.00%> (ø)
...he/pulsar/functions/utils/FunctionConfigUtils.java 72.27% <0.00%> (-0.69%) ⬇️
.../storage/filesystem/FileSystemPackagesStorage.java 58.62% <55.55%> (-9.38%) ⬇️

... and 381 files with indirect coverage changes

@merlimat merlimat merged commit ca8b465 into apache:master Jun 4, 2024
50 checks passed
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
@lhotari
Copy link
Member

lhotari commented Feb 17, 2025

#23985 depends on this change, so cherry-picking branch-3.0 and branch-3.3

lhotari pushed a commit that referenced this pull request Feb 17, 2025
lhotari pushed a commit that referenced this pull request Feb 17, 2025
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Feb 19, 2025
(cherry picked from commit ca8b465)
(cherry picked from commit b4b69c8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants