[fix] [broker] disable loadBalancerMemoryResourceWeight by default #22820
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
|
PTAL, thanks. @lhotari @Demogorgon314 @heesung-sn @BewareMyPower |
|
I start a discussion for this pr: https://lists.apache.org/thread/qpdvyytk8y7x8yzh35jshksnl6498y3r, looking forward to your feedback. |
BewareMyPower
approved these changes
Jun 4, 2024
BewareMyPower
requested review from
lhotari,
Technoboy-,
codelipenghui,
Demogorgon314 and
heesung-sn
Demogorgon314
approved these changes
Jun 4, 2024
|
/pulsarbot rerun-failure-checks |
1 similar comment
|
/pulsarbot rerun-failure-checks |
heesung-sn
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have deprecated
loadBalancerMemoryResourceWeightin PR: #19559, because the memory usage increase all the way until the GC reclaim the space, thus there is no relation between the actual load with the memory usage.But PR: #19559 don't remove all usage of this conf, there is still some logic using this deprecated conf. Meanwhile, there is a try to enhance the memory usage collection by Lari (#21973), so there is possibilty that we may enable this conf again if the memory usage is proved to be related with the actual load.
Based on info aboved, i think that we have better to make the default value of deprecated
loadBalancerMemoryResourceWeightto 0, in such way we can avoid the interference from the memory usage and waiting for Lari's enhancement.Modifications
Change the default value of
loadBalancerMemoryResourceWeightto 0.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: