Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Deprecate unused enableNamespaceIsolationUpdateOnTime config #22449

Merged
merged 1 commit into from
Apr 8, 2024
Merged

[improve][broker] Deprecate unused enableNamespaceIsolationUpdateOnTime config #22449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1453,11 +1453,10 @@ The max allowed delay for delayed delivery (in milliseconds). If the broker rece
doc = "Enable or disable exposing broker entry metadata to client.")
private boolean exposingBrokerEntryMetadataToClientEnabled = false;

@Deprecated
@FieldContext(
category = CATEGORY_SERVER,
doc = "Enable namespaceIsolation policy update take effect ontime or not,"
+ " if set to ture, then the related namespaces will be unloaded after reset policy to make it "
+ "take effect."
doc = "This config never takes effect and will be removed in the next release"
)
private boolean enableNamespaceIsolationUpdateOnTime = false;

Expand Down
3 changes: 2 additions & 1 deletion pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApi2Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,6 @@ protected ServiceConfiguration getDefaultConf() {
void configureDefaults(ServiceConfiguration conf) {
conf.setForceDeleteNamespaceAllowed(true);
conf.setLoadBalancerEnabled(true);
conf.setEnableNamespaceIsolationUpdateOnTime(true);
conf.setAllowOverrideEntryFilters(true);
conf.setEntryFilterNames(List.of());
conf.setMaxNumPartitionsPerPartitionedTopic(0);
Expand Down Expand Up @@ -1394,13 +1393,15 @@ public void brokerNamespaceIsolationPoliciesUpdateOnTime() throws Exception {

try {
admin.lookups().lookupTopic(ns1Name + "/topic3");
fail();
} catch (Exception e) {
// expected lookup fail, because no brokers matched the policy.
log.info(" 2 expected fail lookup");
}

try {
admin.lookups().lookupTopic(ns1Name + "/topic1");
fail();
} catch (Exception e) {
// expected lookup fail, because no brokers matched the policy.
log.info(" 22 expected fail lookup");
Expand Down
Loading