[fix][test] Fix flaky test NonPersistentTopicTest.testMsgDropStat #20387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisonkun
reviewed
May 24, 2023
pulsar-broker/src/test/java/org/apache/pulsar/client/api/NonPersistentTopicTest.java
Show resolved
Hide resolved
tisonkun
approved these changes
May 24, 2023
lifepuzzlefun
approved these changes
May 24, 2023
|
Merging... Thank you! |
2 tasks
lhotari
added a commit
to lhotari/pulsar
that referenced
this pull request
May 25, 2023
…llow up - the previous attempt apache#20387 to fix the flakiness wasn't effective - improve the fix
4 tasks
michaeljmarshall
pushed a commit
that referenced
this pull request
May 25, 2023
…llow up (#20401) Fixes #20386 ### Motivation - the previous attempt #20387 to fix the flakiness wasn't effective ### Modifications - improve the fix and rely on the fact that entryId is -1 when the message is dropped in the broker code: https://github.com/apache/pulsar/blob/091ee2504ffbe6ec98e354b76e7f4c045e1914aa/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java#L1699-L1711 ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added -->
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20386
Motivation
See #20386
Modifications
Use Awaitility in test. Consume and acknowledge messages with messageListener.
Documentation
docdoc-requireddoc-not-neededdoc-complete