Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][monitor] Add JVM start time metric #20381

Merged
merged 1 commit into from
May 24, 2023

Conversation

Technoboy-
Copy link
Contributor

Motivation

Add jvm_start_time to help user get this metric even more accessible than though mbeans

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@Technoboy- Technoboy- added this to the 3.1.0 milestone May 24, 2023
@Technoboy- Technoboy- self-assigned this May 24, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 24, 2023
@Technoboy- Technoboy- added release/2.10.5 release/2.11.2 release/3.0.1 and removed doc-not-needed Your PR changes do not impact docs labels May 24, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 24, 2023
@Technoboy- Technoboy- changed the title [improve][metric] Add JVM start time metric [improve][monitor] Add JVM start time metric May 24, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #20381 (b3477dd) into master (548fd22) will increase coverage by 36.05%.
The diff coverage is 83.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #20381       +/-   ##
=============================================
+ Coverage     36.89%   72.94%   +36.05%     
- Complexity    12053    31891    +19838     
=============================================
  Files          1687     1864      +177     
  Lines        128826   138389     +9563     
  Branches      14013    15184     +1171     
=============================================
+ Hits          47528   100946    +53418     
+ Misses        75040    29440    -45600     
- Partials       6258     8003     +1745     
Flag Coverage Δ
inttests 24.16% <25.00%> (-0.02%) ⬇️
systests 25.00% <41.66%> (-0.18%) ⬇️
unittests 72.22% <83.33%> (+40.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...org/apache/pulsar/common/util/SecurityUtility.java 81.61% <33.33%> (+20.98%) ⬆️
...g/apache/pulsar/broker/admin/impl/BrokersBase.java 70.45% <100.00%> (+33.18%) ⬆️
...rg/apache/pulsar/broker/service/BrokerService.java 80.85% <100.00%> (+24.84%) ⬆️
...ava/org/apache/pulsar/common/stats/JvmMetrics.java 77.02% <100.00%> (+0.63%) ⬆️

... and 1430 files with indirect coverage changes

@Technoboy- Technoboy- merged commit 946acc5 into apache:master May 24, 2023
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jun 6, 2023
Technoboy- added a commit to streamnative/pulsar-archived that referenced this pull request Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants