[improve][doc] Improve doc for delayed message #20374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
changed the title
github-actions
bot
added
the
doc
coderzc
force-pushed
the
improve_delayed_message_doc
branch
from
5e2c5f1 to
ab29df6
Compare
michaeljmarshall
approved these changes
May 23, 2023
|
/pulsarbot rerun-failure-checks |
Anonymitaet
approved these changes
May 24, 2023
| @@ -582,7 +580,7 @@ delayedDeliveryMaxIndexesPerBucketSnapshotSegment=5000 | |||
| delayedDeliveryMaxNumBuckets=-1 | |||
|
|
|||
| # Size of the lookahead window to use when detecting if all the messages in the topic | |||
| # have a fixed delay. | |||
| # have a fixed delay for InMemoryDelayedDeliveryTracker (the default DelayedDeliverTracker). | |||
There was a problem hiding this comment.
Suggested change
| # have a fixed delay for InMemoryDelayedDeliveryTracker (the default DelayedDeliverTracker). | |
| # have a fixed delay for InMemoryDelayedDeliveryTracker (the default value is DelayedDeliverTracker). |
Do you mean this?
There was a problem hiding this comment.
No, the default DelayedDeliverTracker is InMemoryDelayedDeliveryTracker
| @@ -379,7 +377,8 @@ The delayed message index time step(in seconds) in per bucket snapshot segment, | |||
| private int delayedDeliveryMaxNumBuckets = -1; | |||
|
|
|||
| @FieldContext(category = CATEGORY_SERVER, doc = "Size of the lookahead window to use " | |||
| + "when detecting if all the messages in the topic have a fixed delay. " | |||
| + "when detecting if all the messages in the topic have a fixed delay for " | |||
| + "InMemoryDelayedDeliveryTracker (the default DelayedDeliverTracker). " | |||
Codecov Report
@@ Coverage Diff @@
## master #20374 +/- ##
=============================================
+ Coverage 36.89% 72.92% +36.03%
- Complexity 12053 31889 +19836
=============================================
Files 1687 1864 +177
Lines 128826 138387 +9561
Branches 14013 15184 +1171
=============================================
+ Hits 47528 100922 +53394
+ Misses 75040 29465 -45575
- Partials 6258 8000 +1742
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Merging... Thank you @coderzc! |
tisonkun
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Due to PIP-195 introducing
BucketDelayedDeliveryTracker, some document descriptions need to be changed.Modifications
Improve doc for delayed message tracker.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: