[fix][broker] Fix memory leak when rebatchMessage #20369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
added
type/bug
coderzc
force-pushed
the
fix_leak_rebatchmessage
branch
from
8ec8c8f to
4e55e37
Compare
mattisonchao
approved these changes
May 23, 2023
Codecov Report
@@ Coverage Diff @@
## master #20369 +/- ##
=============================================
- Coverage 72.42% 36.84% -35.59%
+ Complexity 31665 12044 -19621
=============================================
Files 1864 1687 -177
Lines 138384 128826 -9558
Branches 15183 14013 -1170
=============================================
- Hits 100223 47460 -52763
- Misses 30160 75096 +44936
+ Partials 8001 6270 -1731
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lhotari
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If there are no retained messages, the memory of brokerMeta will leak. It be introduced by #20337
Modifications
Retain brokerMeta when it really needs.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: