-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Fix ledger cachemiss size metric #20257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We don't need |
The major fix is not the |
Hi @Technoboy- Do you have any other comments:) thanks |
Make sense. So we'd better update the motivation. |
OK. Updated |
(cherry picked from commit 1c813fd)
Motivation
ledger cache miss rate should be same as ledgerFactory cache miss rate. For details, the major fix is that the
count
always increace 1 whenentriesToReturn.size()
is greater thant one, e.g., line453 atRangeEntryCacheImpl.java
Modifications
ledger cache miss rate should be same as ledgerFactory cache miss rate
Verifying this change
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: AnonHxy#38