[improve][bk] Add integration test with bookie http server enabled #20149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tisonkun could you please review this one? |
…tallWithHttpServerEnabledTest
|
I'm reviewing now - I must miss the previous notification :P |
…erverEnabled-20071
Signed-off-by: tison <[email protected]>
tisonkun
approved these changes
May 20, 2023
Codecov Report
@@ Coverage Diff @@
## master #20149 +/- ##
============================================
+ Coverage 33.54% 36.88% +3.33%
+ Complexity 12067 12048 -19
============================================
Files 1610 1687 +77
Lines 125892 128763 +2871
Branches 13704 14003 +299
============================================
+ Hits 42236 47498 +5262
+ Misses 78113 75017 -3096
- Partials 5543 6248 +705
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Merging... Thanks for your contribution @MMirelli! |
15 tasks
lhotari
pushed a commit
that referenced
this pull request
Jun 28, 2023
…20149) Signed-off-by: tison <[email protected]> Co-authored-by: tison <[email protected]> (cherry picked from commit 3f2978d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20071
Motivation
CI didn't have coverage for deploying pulsar with bookie httpServerEnabled.
Modifications
Verifying this change
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: MMirelli#2