[improve][monitor] Introduce new metrics related to transaction buffer snapshot segments #20125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance monitoring capabilities for the transaction buffer snapshot segments by introducing new metrics. These metrics help users better understand the performance and behavior of the transaction buffer, enabling them to make informed decisions for tuning and troubleshooting purposes. ### Modification Introduce new metrics related to transaction buffer snapshot segments, including counters for add, delete, and read operations, as well as gauges and histograms for snapshot indexes and index entry sizes. Additionally, update the `AbortTxnProcessor` to incorporate these new metrics and properly expose them through the Pulsar monitoring system.
github-actions
bot
added
doc-label-missing
doc-not-needed
github-actions
bot
added
doc-required
congbobo184
reviewed
Apr 18, 2023
...org/apache/pulsar/broker/transaction/buffer/impl/SnapshotSegmentAbortedTxnProcessorImpl.java
Outdated
Show resolved
Hide resolved
|
The pr had no activity for 30 days, mark with Stale label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master #16913
Motivation
Enhance monitoring capabilities for the transaction buffer snapshot segments by introducing new metrics. These metrics help users better understand the performance and behavior of the transaction buffer, enabling them to make informed decisions for tuning and troubleshooting purposes.
Modification
Introduce new metrics related to transaction buffer snapshot segments, including counters for add, delete, and read operations, as well as gauges and histograms for snapshot indexes and index entry sizes. Additionally, update the
AbortTxnProcessorto incorporate these new metrics and properly expose them through the Pulsar monitoring system.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: https://github.com/liangyepianzhou/pulsar/pull/31