Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][build] Fix "An error has occurred in JaCoCo report generation" #19229

Merged

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Jan 13, 2023

Fixes #19227

Motivation

Builds fail sporadically with error message An error has occurred in JaCoCo report generation. Error while creating report: Unknown block type 61. in CI. One possible reason is that jacoco write the coverage file in a shutdown hook and this is terminated when surefire.shutdown is set to kill.

Modifications

  • set surefire.shutdown to "exit" when "coverage" profile is active
    • jacoco doesn't support using the surefire.shutdown=kill mode

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: lhotari#131

- set surefire.shutdown to "exit" when "coverage" profile is active
  - jacoco doesn't support using the surefire.shutdown=kill mode
@lhotari
Copy link
Member Author

lhotari commented Jan 13, 2023

Code coverage was activated in #17382 . @yaalsn would you mind reviewing this PR?

@lhotari
Copy link
Member Author

lhotari commented Jan 13, 2023

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2023

Codecov Report

Merging #19229 (3ec88ae) into master (253e3e4) will decrease coverage by 9.70%.
The diff coverage is 42.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #19229      +/-   ##
============================================
- Coverage     46.24%   36.53%   -9.71%     
+ Complexity    10145     7079    -3066     
============================================
  Files           687      633      -54     
  Lines         67483    59919    -7564     
  Branches       7252     6251    -1001     
============================================
- Hits          31208    21892    -9316     
- Misses        32693    35153    +2460     
+ Partials       3582     2874     -708     
Flag Coverage Δ
unittests 36.53% <42.85%> (-9.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pulsar/broker/admin/impl/PersistentTopicsBase.java 19.09% <0.00%> (-40.28%) ⬇️
.../org/apache/pulsar/broker/admin/v2/Namespaces.java 13.50% <0.00%> (-44.79%) ⬇️
...pache/pulsar/broker/admin/v2/PersistentTopics.java 13.38% <0.00%> (-61.42%) ⬇️
...ulsar/broker/intercept/BrokerInterceptorUtils.java 10.71% <0.00%> (ø)
.../broker/loadbalance/impl/PulsarLoadReportImpl.java 0.00% <0.00%> (ø)
...e/pulsar/broker/protocol/ProtocolHandlerUtils.java 10.71% <0.00%> (ø)
...java/org/apache/pulsar/broker/rest/TopicsBase.java 0.00% <0.00%> (ø)
...va/org/apache/pulsar/broker/service/ServerCnx.java 49.44% <ø> (+5.25%) ⬆️
...sar/broker/service/plugin/EntryFilterProvider.java 0.00% <0.00%> (ø)
...org/apache/pulsar/broker/web/ExceptionHandler.java 0.00% <0.00%> (ø)
... and 287 more

@lhotari lhotari merged commit 4ea0d11 into apache:master Jan 13, 2023
@yaalsn
Copy link
Contributor

yaalsn commented Jan 16, 2023

Thanks! Let's have a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build area/ci doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails with "An error has occurred in JaCoCo report generation"
5 participants