[fix][broker] Fix the breaking change of standalone metadata initialization #18909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zation ### Motivation Fix the regression brought by apache#15186. See https://lists.apache.org/thread/vz3tqpgs5l1r0trq29r4hdf85t0rjc8j for details. ### Modifications Use `PulsarAdmin` to initialize the metadata so that it would fail if the authentication of the built-in clients were not configured correctly. Add a `testMetadataInitialization` to avoid the regression. And move the bundle policy test from `SmokeTest` to this test. xxx
BewareMyPower
added
release/blocker
BewareMyPower
requested review from
nodece,
merlimat,
codelipenghui,
eolivelli,
Jason918,
lhotari,
tisonkun,
Demogorgon314 and
Technoboy-
|
When cherry-picking this PR to branch-2.11, we need to push another commit to update the Change $PULSAR_DIR/bin/pulsar-admin tenants update public -r "anonymous" -c "standalone"
# Update "public/default" with no auth requiredto $PULSAR_DIR/bin/pulsar-admin tenants create public -r "anonymous" -c "standalone"
# Create "public/default" with no auth required
$PULSAR_DIR/bin/pulsar-admin namespaces create public/default/cc @Technoboy- |
4 tasks
Demogorgon314
approved these changes
Dec 13, 2022
nicoloboschi
approved these changes
Dec 13, 2022
Codecov Report
@@ Coverage Diff @@
## master #18909 +/- ##
============================================
+ Coverage 48.59% 53.52% +4.93%
+ Complexity 8385 7756 -629
============================================
Files 494 414 -80
Lines 54445 44692 -9753
Branches 5812 4576 -1236
============================================
- Hits 26458 23923 -2535
+ Misses 24968 18190 -6778
+ Partials 3019 2579 -440
Flags with carried forward coverage won't be shown. Click here to find out more. |
congbobo184
approved these changes
Dec 14, 2022
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Dec 14, 2022
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix the regression brought by #15186. See
https://lists.apache.org/thread/vz3tqpgs5l1r0trq29r4hdf85t0rjc8j for details.
Modifications
Use
PulsarAdminto initialize the metadata so that it would fail if the authentication of the built-in clients were not configured correctly.Add a
testMetadataInitializationto avoid the regression. And move the bundle policy test fromSmokeTestto this test.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: BewareMyPower#14