-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor][doc] Improve schema docs #18434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work! Leave some style suggestions in the comments.
@labuladong thanks for your review. Comments have been addressed. PTAL. @congbobo184 @liangyepianzhou @RobertIndie Do you have any other review comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I left some comments here.
@RobertIndie @labuladong Thanks very much for your concrete review. Comments have been addressed. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your great work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me~
Motivation
This is a follow-up PR to #18242 to improve the Schema docs, aiming to provide Pulsar users with a more accurate, easy-to-read, and comprehensive information experience.
Modifications
The content is revised and reviewed through Google docs.
How Pulsar schema works
.schema evolution
and subtopics intoUnderstand schema
.native Avro
tostruct
schema.Many thanks to @congbobo184, @liangyepianzhou and @RobertIndie for providing technical inputs and review comments.
//cc @Anonymitaet @DaveDuggins @D-2-Ed
Documentation
doc
doc-required
doc-not-needed
doc-complete