-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][misc] use SLASHSTAR_STYLE for Java files #17508
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: tison <[email protected]>
7d87bc1
to
8b74cd8
Compare
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
ping @eolivelli @codelipenghui @lhotari @Jason918 :) |
@merlimat what do you think of this proposal? |
Signed-off-by: tison <[email protected]>
The pr had no activity for 30 days, mark with Stale label. |
Closed for a brand new patch. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc-not-needed
!THIS IS A TRIVIAL CHANGE!
The effective change is 40f4fea.
Then run
mvn initialize license:format
to change:to:
Motivation
When reformatting Java files, JAVADOC_STYLE cause the license header be treated as doc comments and it will be affected from:
to
This is annoying while we can replace JAVADOC_STYLE with SLASHSTAR_STYLE and it won't be an issue anymore.
Since I can simply rerun the command and even other patches should never touch these lines, this patch isn't in a hurry or suffers from conflict. But since we don't require all PR to be up-to-date before merging, we can experience a stage master failed on
license:check
.