Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][workflow] Upgrade to latest docbot action #17266

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

maxsxu
Copy link
Contributor

@maxsxu maxsxu commented Aug 25, 2022

Master Issue: #15797 apache/pulsar-test-infra#67

Motivation

Simplify invocation of docbot action

Modifications

Upgrade to latest docbot action

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@maxsxu
Copy link
Contributor Author

maxsxu commented Aug 25, 2022

We need to merge with this PR simultaneously.

/cc @tisonkun @Anonymitaet @lhotari

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should merge this patch after apache/pulsar-test-infra#68 merged?

.github/workflows/ci-documentbot.yml Outdated Show resolved Hide resolved
@Anonymitaet Anonymitaet added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. workflow labels Aug 25, 2022
@Anonymitaet Anonymitaet added this to the 2.12.0 milestone Aug 25, 2022
@maxsxu
Copy link
Contributor Author

maxsxu commented Aug 25, 2022

@nodece has helped merged the apache/pulsar-test-infra#68
We can merge this PR now as the pulsar-test-infra/docbot is updated.

@Anonymitaet
Copy link
Member

/pulsarbot run-failure-checks

@Anonymitaet
Copy link
Member

/pulsarbot run-failure-checks

@maxsxu maxsxu force-pushed the refactor-docbot branch 2 times, most recently from 600b061 to 4eb1a42 Compare August 26, 2022 10:09
@maxsxu
Copy link
Contributor Author

maxsxu commented Aug 26, 2022

/pulsarbot run-failure-checks

@Anonymitaet These failure checks introduced in master is irrelevant to this PR.

@Anonymitaet Anonymitaet merged commit 438cdfe into apache:master Aug 29, 2022
@maxsxu maxsxu deleted the refactor-docbot branch August 29, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants