Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][workflow] Remove label event of docbot #16437

Closed
wants to merge 1 commit into from

Conversation

maxsxu
Copy link
Contributor

@maxsxu maxsxu commented Jul 7, 2022

Master Issue: #15797

Motivation

It seems the labeled event and unlabled event will trigger github actions hang.

Modifications

Remove label and unlabeled event of docbot.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

It seems labeled event and unlabled event will trigger
github actions hang.

Signed-off-by: Max Xu <[email protected]>
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 7, 2022
@dave2wave
Copy link
Member

/pulsarbot run-failure-checks

@dave2wave dave2wave mentioned this pull request Jul 7, 2022
2 tasks
Copy link
Member

@dave2wave dave2wave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't fix the problem with the docbot blocking PRs. I think that this PR should be reconsidered. The proper fix should be #16453

@Anonymitaet
Copy link
Member

@maxsxu do we need to re-submit this change?

@maxsxu
Copy link
Contributor Author

maxsxu commented Jul 8, 2022

@maxsxu do we need to re-submit this change?

Let's observe for a while.

@maxsxu maxsxu deleted the fix/docbot-pending branch August 27, 2022 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants