Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ServerCnx] Improve error logging for topic not found #13950

Merged
merged 2 commits into from
Jan 28, 2022
Merged

[ServerCnx] Improve error logging for topic not found #13950

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b124290
[ServerCnx] Improve error logging for topic not found
michaeljmarshall Jan 25, 2022
027095c
Log topic not found at INFO level
michaeljmarshall Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1273,12 +1273,13 @@ protected void handleProducer(final CommandProducer cmdProducer) {
return null;
}

// Do not print stack traces for expected exceptions
if (cause instanceof NoSuchElementException) {
cause = new TopicNotFoundException("Topic Not Found.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could also try to not create a 2nd exception here which is only used to do getMessage()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, although we also use the exception here: BrokerServiceException.getClientErrorCode(cause).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@merlimat - would you like me to introduce more complicated logic for getting the client error code, or is this sufficient?

}
if (!Exceptions.areExceptionsPresentInChain(cause,
log.info("[{}] Failed to load topic {}, producerId={}: Topic not found", remoteAddress, topicName,
producerId);
} else if (!Exceptions.areExceptionsPresentInChain(cause,
ServiceUnitNotReadyException.class, ManagedLedgerException.class)) {
// Do not print stack traces for expected exceptions
log.error("[{}] Failed to create topic {}, producerId={}",
remoteAddress, topicName, producerId, exception);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it still print the exception stack in exception ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still prints the exception stack here, but it doesn't for exceptions that have a cause of type NoSuchElementException. I relocated the comment because we're avoiding printing stack traces in this conditional block.

}
Expand Down