Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Broker] Fix call sync method in async rest api for internalTerminatePartitionedTopic #13890

Merged
merged 3 commits into from
Jan 24, 2022
Merged

[Broker] Fix call sync method in async rest api for internalTerminatePartitionedTopic #13890

merged 3 commits into from
Jan 24, 2022

Conversation

liudezhi2098
Copy link
Contributor

Motivation

Avoid call sync method in async rest API for PersistentTopicsBase#internalTerminatePartitionedTopic.

Modifications

  • Use async instead of sync method.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Need to update docs?

  • no-need-doc

@codelipenghui codelipenghui added this to the 2.10.0 milestone Jan 21, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 21, 2022
@liudezhi2098
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui merged commit 1ceab68 into apache:master Jan 24, 2022
@Jason918 Jason918 mentioned this pull request Jan 25, 2022
Closed
26 tasks
@Technoboy- Technoboy- mentioned this pull request May 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaozhangmin gaozhangmin gaozhangmin approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@mattisonchao mattisonchao mattisonchao approved these changes

@Jason918 Jason918 Awaiting requested review from Jason918

Assignees

@liudezhi2098 liudezhi2098

Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@liudezhi2098 @Jason918 @gaozhangmin @codelipenghui @mattisonchao