[Issue 13854][broker] Fix call sync method in async rest api for internalSetReplicatedSubscriptionStatus #13887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
4578
to
4579
| private CompletableFuture<Void> internalSetReplicatedSubscriptionStatusForNonPartitionedTopicAsync(AsyncResponse asyncResponse, | ||
| String subName,boolean authoritative,boolean enabled) { |
There was a problem hiding this comment.
Suggested change
| private CompletableFuture<Void> internalSetReplicatedSubscriptionStatusForNonPartitionedTopicAsync(AsyncResponse asyncResponse, | |
| String subName,boolean authoritative,boolean enabled) { | |
| private CompletableFuture<Void> internalSetReplicatedSubscriptionStatusForNonPartitionedTopicAsync(AsyncResponse asyncResponse, | |
| String subName, boolean authoritative, boolean enabled) { |
| private CompletableFuture<Void> internalSetReplicatedSubscriptionStatusForNonPartitionedTopicAsync(AsyncResponse asyncResponse, | ||
| String subName,boolean authoritative,boolean enabled) { | ||
| // Redirect the request to the appropriate broker if this broker is not the owner of the topic | ||
| return validateTopicOwnershipAsync(topicName, authoritative).thenRun(() -> { | ||
| Topic topic = getTopicReference(topicName); |
| // 2.Redirect the request to the peer-cluster if the local cluster is not included in the replication clusters | ||
| CompletableFuture<Void> future = | ||
| validateTopicOperationAsync(topicName, TopicOperation.SET_REPLICATED_SUBSCRIPTION_STATUS, subName) | ||
| .thenCompose(__-> validateGlobalNamespaceOwnershipAsync(namespaceName)); |
There was a problem hiding this comment.
Suggested change
| .thenCompose(__-> validateGlobalNamespaceOwnershipAsync(namespaceName)); | |
| .thenCompose(__ -> validateGlobalNamespaceOwnershipAsync(namespaceName)); |
| validateTopicOwnership(topicName, authoritative); | ||
|
|
||
| private CompletableFuture<Void> internalSetReplicatedSubscriptionStatusForNonPartitionedTopicAsync(AsyncResponse asyncResponse, | ||
| String subName,boolean authoritative,boolean enabled) { |
There was a problem hiding this comment.
Suggested change
| String subName,boolean authoritative,boolean enabled) { | |
| String subName, boolean authoritative, boolean enabled) { |
| subName); | ||
| asyncResponse.resume(Response.noContent().build()); | ||
| } else { | ||
| asyncResponse.resume(new RestException(Status.METHOD_NOT_ALLOWED, | ||
| "Cannot enable/disable replicated subscriptions on non-persistent topics")); | ||
| } | ||
| } catch (Exception e) { | ||
| }).exceptionally(e -> { | ||
| resumeAsyncResponseExceptionally(asyncResponse, e); |
There was a problem hiding this comment.
- Maybe we need
e.getCausehere. - We need log some information when get exception.
suiyuzeng
force-pushed
the
sync_call_issue_internalSetReplicatedSubscriptionStatus
branch
from
408b069 to
e4eecb2
Compare
Jason918
reviewed
Jan 21, 2022
| enabled, topicName, subName, ex); | ||
| resumeAsyncResponseExceptionally(asyncResponse, ex); | ||
| return null; | ||
| }); | ||
| } else { | ||
| getPartitionedTopicMetadataAsync(topicName, authoritative, false).thenAccept(partitionMetadata -> { |
There was a problem hiding this comment.
Need future.thenCompose here. This should be executed after previous validation is finished.
Jason918
reviewed
Jan 21, 2022
| @@ -4565,8 +4563,8 @@ protected void internalSetReplicatedSubscriptionStatus(AsyncResponse asyncRespon | |||
| return null; | |||
| }); | |||
| } else { | |||
| internalSetReplicatedSubscriptionStatusForNonPartitionedTopic(asyncResponse, subName, authoritative, | |||
| enabled); | |||
| internalSetReplicatedSubscriptionStatusForNonPartitionedTopicAsync(asyncResponse, subName, | |||
There was a problem hiding this comment.
No need to add "Async", let's keep it consistent with other methods.
26 tasks
suiyuzeng
force-pushed
the
sync_call_issue_internalSetReplicatedSubscriptionStatus
branch
2 times, most recently
from
e4a9897 to
d5f4da8
Compare
suiyuzeng
force-pushed
the
sync_call_issue_internalSetReplicatedSubscriptionStatus
branch
from
d5f4da8 to
fbd70aa
Compare
Jason918
approved these changes
Jan 25, 2022
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
mattisonchao
approved these changes
Jan 27, 2022
codelipenghui
approved these changes
Jan 28, 2022
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
…rnalSetReplicatedSubscriptionStatus (apache#13887)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #13854
Motivation
See #13854
Verifying this change
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
no-need-doc