-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 11338: add documentation about the upgrade of Pulsar 2.8.0 #11392
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my understanding, for Kubernetes users, we need to take into account the runtime which users using. If users use thread or process runtime, then they should keep functions worker pod with a previous version of Pulsar. If users use Kubernetes runtime, they should keep the
functionRuntimeFactoryConfigs.functionDockerImages
orfunctionRuntimeFactoryConfigs.pulsarDockerImageName
with previous version of Pulsar infunctions_worker.yml
as well, because by default it will useapachepulsar/pulsar:latest
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even this is technically possible,
it is not simple to configure this parameter in a multi tenant environment, it is practically impossible, because you have to take care of the placement of the functions for each tenant.
Also we do not guarantee (it is not stated anywhere and there is no testcase) that the 'function worke' is able to work with a more recent version of the broker or of the other components.
In practice if you upgrade from 2.7.x to 2.8.x you can keep the function pods at version Pulsar 2.7.x, but this is not something that I would recommend to the public audience, as it needs some advanced knowledge of Pulsar internals
if the default is 'apachepulsar/pulsar:latest' this is kind of a bad problem, because in this case everything may break without notice.
if you are using the official Apache Pulsar Helm Chart we are setting properly the version
does this make sense to you @freeznet ?