[Fix] Fix the dispatcher() stuck caused by availablePermitsCh #875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
availablePermitsCh
may cause the dispatcher stuck.pulsar-client-go/pulsar/consumer_partition.go
Lines 1096 to 1109 in 0b0720a
For example, if
messageCh <- nextMessage
continueously selected 10 times, theavailablePermitsCh
will be filled. The nextmessageCh <- nextMessage
will be stuck forever becausepr := <-pc.availablePermitsCh
can never be reached.Modifications
Remove the
pc.availablePermitsCh
from dispatcher.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: