Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to github.com/golang-jwt/jwt/v4 #686

Closed
wants to merge 1 commit into from

Conversation

freeznet
Copy link
Contributor

@freeznet freeznet commented Dec 22, 2021

#524 resolves the jwt vulnerability by update the dependency to github.com/form3tech-oss/jwt-go v3.2.3+incompatible, but github.com/form3tech-oss/jwt-go is no longer maintain and suggested move to github.com/golang-jwt/jwt.

@freeznet freeznet self-assigned this Dec 22, 2021
@freeznet freeznet changed the title move to golang-jwt/jwt/v4 move to github.com/golang-jwt/jwt/v4 Dec 22, 2021
@wolfstudy wolfstudy added this to the v0.8.0 milestone Dec 24, 2021
@wolfstudy
Copy link
Member

@freeznet Please check action CI, thanks

@wolfstudy
Copy link
Member

# github.com/golang-jwt/jwt/v4
Error: ../../../go/pkg/mod/github.com/golang-jwt/jwt/[email protected]/ecdsa.go:135:4: r.FillBytes undefined (type *big.Int has no field or method FillBytes)
Error: ../../../go/pkg/mod/github.com/golang-jwt/jwt/[email protected]/ecdsa.go:136:4: s.FillBytes undefined (type *big.Int has no field or method FillBytes)

@freeznet
Copy link
Contributor Author

@wolfstudy I might close this PR first, since it turns that the latest golang-jwt/jwt/v4 requires at least go 1.15 since the FillBytes is added from 1.15 (ref: https://pkg.go.dev/math/big#Int.FillBytes)

@freeznet freeznet closed this Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants