-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encryption support ext consumer #612
Merged
wolfstudy
merged 25 commits into
apache:master
from
Fanatics:encryption-support-ext-consumer
Oct 9, 2021
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
d8bb8fe
add ability to encrypt messages
aa40a8d
fix typo
3b8d912
lint fixes
e1a8108
address review suggestions
d200b7c
revert go mod
feaf120
remove encryption context
a2bd72b
try to fix check issues
f204347
Merge branch 'master' into encryption-support-ext-producer
GPrabhudas a561923
remove unused code
559dbaf
Merge branch 'encryption-support-ext-producer' of https://github.com/…
f0ab398
consumer encryption/decryption changes
d7246bc
remove embedded crypto struct
f9c23e9
Merge branch 'encryption-support-ext-producer' into encryption-suppor…
3939030
remove embedded struct
2ab2e20
add comments
b342a8d
Merge branch 'master' into encryption-support-ext-consumer
134ae2e
merge conflict issues fix
f27838f
add noop decryptor
b296c27
lint fixes
56915e8
fix test case
6012ae1
refactor and reader encryption changes
85622e6
refactor
1fea522
address review feedback
f35c3c9
Nack on decryption failure
f441348
add comment on test case
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The java clients add this to the unacked message tracker do we need to do the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me take a look at this..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have this so may we just need to ack the message so it's not resent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, but i don't think it is good idea to do
ack
.Let's say user wants to consume this message again by providing proper crypto configuration, if we do
ack
, then he may not be able to consume.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I think it's better to resend the message than doing
ack
.Any other thoughts here ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can do nack. I'll push changes with nack on failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cckellogg I've made the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me will you please fix the CI issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @cckellogg
I don't think CI is failing due to last commit.
I see most of the open PR's are failing with the same issue as below.
TestNamespaceTopicsNamespaceDoesNotExit (56.25s) client_impl_test.go:387: Error Trace: client_impl_test.go:387 Error: Expected nil, but got: &errors.errorString{s:"server error: AuthorizationError: Exception occurred while trying to authorize GetTopicsOfNamespace"} Test: TestNamespaceTopicsNamespaceDoesNotExit
And last commit do not have any changes that effects
client_impl.go
. More likely this has something to do with broker config that CI uses for running test cases.please let me know If I'm wrong here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cckellogg looks like the CI is passed now.
Please do suggest if there are any other improvements on this PR.