Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#550 fix race condition when resend pendingItems #551

Merged
merged 1 commit into from
Jun 24, 2021
Merged

#550 fix race condition when resend pendingItems #551

merged 1 commit into from
Jun 24, 2021

Conversation

freeznet
Copy link
Contributor

@freeznet freeznet commented Jun 24, 2021 •
edited
Loading

Fixes #550

Modifications

When resending pendingItems, reset the pendingItem's sentAt and put the pendingItem to the back of pendingItems queue.

Verifying this change

  • Make sure that the change passes the CI checks.

@freeznet
Copy link
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@freeznet
Copy link
Contributor Author

/pulsarbot run-failure-checks

@merlimat merlimat added this to the 0.6.0 milestone Jun 24, 2021
@merlimat merlimat merged commit 98338e5 into apache:master Jun 24, 2021
@geniusjoe geniusjoe mentioned this pull request Jul 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@merlimat merlimat merlimat approved these changes

Assignees

@freeznet freeznet

Labels
type/bug
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

data race when reconnecting to broker and resending pendingItems
3 participants
@freeznet @merlimat @sijie