close dangling autoDiscovery goroutine in consumer #411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The goroutine for auto discovery partitions has never been closed even when consumer is Close()
https://github.com/apache/pulsar-client-go/blob/v0.3.0/pulsar/consumer_impl.go#L236
Currently consumer Close() will stop() the ticker, however, Stop() does not close the ticker's channel. The behaviour is described at https://golang.org/pkg/time/#Ticker.Stop
This bug can leave a large number of dangling goroutines, that results in high CPU consumption.
Modifications
The fix is to introduce a signal channel to send a signal to terminate the partition auto discovery goroutine upon consumer Close().
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation