Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support OAuth2 with scope field #1097

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Support OAuth2 with scope field #1097

merged 2 commits into from
Sep 25, 2023

Conversation

labuladong
Copy link
Contributor

@labuladong labuladong commented Sep 22, 2023 •
edited
Loading

Motivation

Current pulsaradmin OAuth2 params don't support to input the scope field. Add a function to implement it. ClientCredentialsFlowOptions has a AdditionalScopes field to set scopes.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@labuladong labuladong force-pushed the donglai/support-oauth-scope branch from 63d8679 to 8d3708d Compare September 22, 2023 07:33
@labuladong labuladong changed the title support scope Support OAuth2 with scope field Sep 22, 2023
@labuladong labuladong marked this pull request as ready for review September 22, 2023 07:37
@labuladong labuladong mentioned this pull request Sep 22, 2023
Merged
4 tasks
@ericsyh
Copy link
Contributor

ericsyh commented Sep 22, 2023

@zymap @tuteng @RobertIndie PTAL

@ericsyh
Copy link
Contributor

ericsyh commented Sep 22, 2023

@labuladong pls take a look the lint from CI

@labuladong
Copy link
Contributor Author

fixed

maxsxu
maxsxu approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@maxsxu maxsxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RobertIndie RobertIndie merged commit ac9c1a6 into apache:master Sep 25, 2023
@labuladong labuladong deleted the donglai/support-oauth-scope branch September 25, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsxu maxsxu maxsxu approved these changes

@shibd shibd shibd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@labuladong @ericsyh @maxsxu @shibd @RobertIndie