Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Outdated interface description of SeekByTime #923

Closed
Gleiphir2769 opened this issue Dec 22, 2022 · 0 comments · Fixed by #924
Closed

[BUG] Outdated interface description of SeekByTime #923

Gleiphir2769 opened this issue Dec 22, 2022 · 0 comments · Fixed by #924

Comments

@Gleiphir2769
Copy link
Contributor

I noticed that the interface description of SeekByTime is outdated.

// SeekByTime resets the subscription associated with this consumer to a specific message publish time.
//
// Note: this operation can only be done on non-partitioned topics. For these, one can rather perform the seek() on
// the individual partitions.
//
// @param time
// the message publish time when to reposition the subscription
//
SeekByTime(time time.Time) error

The currently interface description said Seek() and SeekByTime() does not support partitioned topic consumer. But in #782 , @GPrabhudas has introduced the consumer seek by time on partitioned topic.

I think we should remove the legacy interface description of SeekByTime

@Gleiphir2769 Gleiphir2769 changed the title [BUG] Legacy interface description of SeekByTime [BUG] Outdated interface description of SeekByTime Dec 22, 2022
wolfstudy pushed a commit that referenced this issue Dec 23, 2022
Remove the outdated interface description of SeekByTime. More details here #923.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant