Skip to content

Commit

Permalink
[ISSUE-328] test if there is no message
Browse files Browse the repository at this point in the history
Signed-off-by: Paulo Pereira <[email protected]>
  • Loading branch information
Paulo Pereira committed Jul 22, 2020
1 parent d410552 commit d64fffc
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 4 deletions.
14 changes: 10 additions & 4 deletions pulsar/consumer_partition.go
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,10 @@ const (
nonDurable
)

const (
noMessageEntry = -1
)

type partitionConsumerOpts struct {
topic string
consumerName string
Expand Down Expand Up @@ -198,11 +202,13 @@ func newPartitionConsumer(parent Consumer, client *client, options *partitionCon
if err != nil {
return nil, err
}
pc.startMessageID = msgID
if msgID.entryID != noMessageEntry {
pc.startMessageID = msgID

err = pc.requestSeek(msgID)
if err != nil {
return nil, err
err = pc.requestSeek(msgID)
if err != nil {
return nil, err
}
}
}

Expand Down
12 changes: 12 additions & 0 deletions pulsar/reader_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -458,6 +458,18 @@ func TestReaderLatestInclusiveHasNext(t *testing.T) {
topic := newTopicName()
ctx := context.Background()

// create reader on the last message (inclusive)
reader0, err := client.CreateReader(ReaderOptions{
Topic: topic,
StartMessageID: LatestMessageID(),
StartMessageIDInclusive: true,
})

assert.Nil(t, err)
defer reader0.Close()

assert.False(t, reader0.HasNext())

// create producer
producer, err := client.CreateProducer(ProducerOptions{
Topic: topic,
Expand Down

0 comments on commit d64fffc

Please sign in to comment.