Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue23555][pulsar-adapters] 4.0.0 release of pulsar-client-kafka adaptor #59

Merged
merged 11 commits into from
Dec 20, 2024

Conversation

visxu
Copy link
Contributor

@visxu visxu commented Nov 20, 2024

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes # apache/pulsar#23555

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Release Pulsar-adapters to support Pulsar4.0.0

Modifications

  1. Upgrade Pulsar dependency version to 4.0.0
  2. Set jcommander version to 1.82
  3. Set mockito-core version to 3.12.4

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (don't know)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

- upgrade Pulsar to 4.0.0
- set `jcommander` version to 1.82
- Set `mockito-core` version to 3.12.4
Copy link
Member

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! I left some comments, please check.

@visxu
Copy link
Contributor Author

visxu commented Dec 3, 2024

Hi, @nodece . Please help to review it if you're available, tks.

- Change version to `4.0.0-SNAPSHOT`
Use `4.0.1` version in test.

Co-authored-by: Zixuan Liu <[email protected]>
@nodece
Copy link
Member

nodece commented Dec 17, 2024

@visxu Please fix CI.

- change dependency path, `javax.xxx` -> `jakarta.xxx`
- `ConsumerName.java` has been removed. Replace ConsumerName#generateRandomName with RandomStringUtils#randomAlphanumeric (#23645)
- change docker image version.
- change docker image version.
- change docker image version.
- fix docker tag error
@nodece nodece merged commit 305229d into apache:master Dec 20, 2024
2 checks passed
AnuragReddy2000 pushed a commit to AnuragReddy2000/pulsar-adapters that referenced this pull request Jan 29, 2025
…aptor (apache#59)

* Fix issue: apache/pulsar#23555.
- upgrade Pulsar to 4.0.0

* Fix issue: apache/pulsar#23555.
- set `jcommander` version to 1.82

* Fix issue: apache/pulsar#23555.
- Set `mockito-core` version to 3.12.4

* Fix issue: apache/pulsar#23555.
- Change version to `4.0.0-SNAPSHOT`

* Apply suggestions from code review

Use `4.0.1` version in test.

Co-authored-by: Zixuan Liu <[email protected]>

* Fix issue: apache/pulsar#23555.
- change dependency path, `javax.xxx` -> `jakarta.xxx`

* Fix issue: apache/pulsar#23555.
- `ConsumerName.java` has been removed. Replace ConsumerName#generateRandomName with RandomStringUtils#randomAlphanumeric (#23645)

* Fix issue: apache/pulsar#23555.
- change docker image version.

* Fix issue: apache/pulsar#23555.
- change docker image version.

* Fix issue: apache/pulsar#23555.
- change docker image version.

* Fix issue: apache/pulsar#23555.
- fix docker tag error

---------

Co-authored-by: Zixuan Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants