-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue23555][pulsar-adapters] 4.0.0 release of pulsar-client-kafka adaptor #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- upgrade Pulsar to 4.0.0
- set `jcommander` version to 1.82
- Set `mockito-core` version to 3.12.4
nodece
reviewed
Nov 21, 2024
nodece
reviewed
Nov 21, 2024
nodece
requested changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! I left some comments, please check.
Hi, @nodece . Please help to review it if you're available, tks. |
- Change version to `4.0.0-SNAPSHOT`
nodece
reviewed
Dec 17, 2024
nodece
reviewed
Dec 17, 2024
nodece
reviewed
Dec 17, 2024
nodece
reviewed
Dec 17, 2024
nodece
reviewed
Dec 17, 2024
nodece
reviewed
Dec 17, 2024
Use `4.0.1` version in test. Co-authored-by: Zixuan Liu <[email protected]>
nodece
approved these changes
Dec 17, 2024
@visxu Please fix CI. |
- change dependency path, `javax.xxx` -> `jakarta.xxx`
- `ConsumerName.java` has been removed. Replace ConsumerName#generateRandomName with RandomStringUtils#randomAlphanumeric (#23645)
nodece
approved these changes
Dec 19, 2024
- change docker image version.
- change docker image version.
nodece
reviewed
Dec 20, 2024
nodece
reviewed
Dec 20, 2024
- change docker image version.
- fix docker tag error
AnuragReddy2000
pushed a commit
to AnuragReddy2000/pulsar-adapters
that referenced
this pull request
Jan 29, 2025
…aptor (apache#59) * Fix issue: apache/pulsar#23555. - upgrade Pulsar to 4.0.0 * Fix issue: apache/pulsar#23555. - set `jcommander` version to 1.82 * Fix issue: apache/pulsar#23555. - Set `mockito-core` version to 3.12.4 * Fix issue: apache/pulsar#23555. - Change version to `4.0.0-SNAPSHOT` * Apply suggestions from code review Use `4.0.1` version in test. Co-authored-by: Zixuan Liu <[email protected]> * Fix issue: apache/pulsar#23555. - change dependency path, `javax.xxx` -> `jakarta.xxx` * Fix issue: apache/pulsar#23555. - `ConsumerName.java` has been removed. Replace ConsumerName#generateRandomName with RandomStringUtils#randomAlphanumeric (#23645) * Fix issue: apache/pulsar#23555. - change docker image version. * Fix issue: apache/pulsar#23555. - change docker image version. * Fix issue: apache/pulsar#23555. - change docker image version. * Fix issue: apache/pulsar#23555. - fix docker tag error --------- Co-authored-by: Zixuan Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(If this PR fixes a github issue, please add
Fixes #<xyz>
.)Fixes # apache/pulsar#23555
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>
to link to the master issue.)Master Issue: #
Motivation
Release Pulsar-adapters to support Pulsar4.0.0
Modifications
jcommander
version to 1.82mockito-core
version to 3.12.4Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation