Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow gauge stored in metric registry to be updated #9961

Merged
merged 3 commits into from
Dec 15, 2022

Conversation

zhtaoxiang
Copy link
Contributor

Currently, if a gauge is created and save into a metric registry, it cannot be updated. This PR makes it changable.

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2022

Codecov Report

Attention: Patch coverage is 50.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 70.39%. Comparing base (b3d1ac3) to head (55adf9a).
Report is 2540 commits behind head on master.

Files with missing lines Patch % Lines
...not/plugin/metrics/yammer/YammerSettableGauge.java 27.27% 8 Missing ⚠️
...pache/pinot/plugin/metrics/yammer/YammerGauge.java 44.44% 5 Missing ⚠️
.../java/org/apache/pinot/spi/metrics/PinotGauge.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #9961      +/-   ##
============================================
+ Coverage     70.37%   70.39%   +0.02%     
- Complexity     5071     5657     +586     
============================================
  Files          1987     1991       +4     
  Lines        106761   107206     +445     
  Branches      16203    16289      +86     
============================================
+ Hits          75134    75472     +338     
- Misses        26385    26459      +74     
- Partials       5242     5275      +33     
Flag Coverage Δ
integration1 25.03% <33.33%> (-0.13%) ⬇️
integration2 24.53% <33.33%> (+0.03%) ⬆️
unittests1 67.88% <77.77%> (+0.05%) ⬆️
unittests2 13.59% <0.00%> (-2.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhtaoxiang zhtaoxiang force-pushed the allow-gauge-to-be-updated branch from 906b9eb to e4ad7fb Compare December 11, 2022 00:58
@snleee snleee requested a review from jackjlli December 12, 2022 21:43
Copy link
Contributor

@snleee snleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for adding this!

@snleee snleee merged commit 8bb551e into apache:master Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants