Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back the Helix workaround for missing IS change #9921

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

Jackie-Jiang
Copy link
Contributor

Adds back the Helix workaround introduced in #4459 and removed in #9634.
Seems the issue is still not fixed in helix-1.0.4, so submitted a separate issue apache/helix#2309.

This workaround can fix #9897, but currently only applied to the tests

Copy link
Contributor

@walterddr walterddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2022

Codecov Report

Merging #9921 (86b87f7) into master (e6a9881) will decrease coverage by 4.69%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9921      +/-   ##
============================================
- Coverage     68.97%   64.27%   -4.70%     
+ Complexity     5058     5035      -23     
============================================
  Files          1982     1928      -54     
  Lines        106433   104004    -2429     
  Branches      16127    15838     -289     
============================================
- Hits          73409    66853    -6556     
- Misses        27877    32326    +4449     
+ Partials       5147     4825     -322     
Flag Coverage Δ
integration2 ?
unittests1 67.95% <ø> (+<0.01%) ⬆️
unittests2 15.82% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/org/apache/pinot/common/config/NettyConfig.java 0.00% <0.00%> (-100.00%) ⬇️
...a/org/apache/pinot/common/metrics/MinionMeter.java 0.00% <0.00%> (-100.00%) ⬇️
...g/apache/pinot/common/metrics/ControllerMeter.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/BrokerQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/MinionQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
...ache/pinot/server/access/AccessControlFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...he/pinot/common/messages/SegmentReloadMessage.java 0.00% <0.00%> (-100.00%) ⬇️
...he/pinot/common/messages/TableDeletionMessage.java 0.00% <0.00%> (-100.00%) ⬇️
...pinot/core/data/manager/realtime/TimerService.java 0.00% <0.00%> (-100.00%) ⬇️
...not/common/exception/HttpErrorStatusException.java 0.00% <0.00%> (-100.00%) ⬇️
... and 385 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@walterddr walterddr merged commit 173916e into apache:master Dec 7, 2022
@Jackie-Jiang Jackie-Jiang deleted the helix_workaround branch December 7, 2022 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky-test] ZKOperatorTest.testMetadataUploadType
6 participants