Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: fix segment status color remains same in different table page #9891

Merged

Conversation

jayeshchoudhary
Copy link
Contributor

What does this PR do?

  • fix segment status color remains same in different table page

Screenshot

before

segment-status-bug-before.mp4

after

segment-status-after.mp4

@codecov-commenter
Copy link

Codecov Report

Merging #9891 (5da3b9e) into master (9690b2d) will decrease coverage by 9.19%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9891      +/-   ##
============================================
- Coverage     24.99%   15.79%   -9.20%     
- Complexity       44      175     +131     
============================================
  Files          1966     1925      -41     
  Lines        105835   103763    -2072     
  Branches      16056    15806     -250     
============================================
- Hits          26451    16390   -10061     
- Misses        76709    86178    +9469     
+ Partials       2675     1195    -1480     
Flag Coverage Δ
integration1 ?
unittests2 15.79% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/main/java/org/apache/pinot/sql/FilterKind.java 0.00% <0.00%> (-100.00%) ⬇️
...ain/java/org/apache/pinot/core/data/table/Key.java 0.00% <0.00%> (-100.00%) ⬇️
...n/java/org/apache/pinot/core/data/table/Table.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/core/data/table/Record.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/core/util/GroupByUtils.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/common/auth/AuthConfig.java 0.00% <0.00%> (-100.00%) ⬇️
...va/org/apache/pinot/core/routing/RoutingTable.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/sql/parsers/PinotSqlType.java 0.00% <0.00%> (-100.00%) ⬇️
...a/org/apache/pinot/core/operator/BaseOperator.java 0.00% <0.00%> (-100.00%) ⬇️
...va/org/apache/pinot/common/config/NettyConfig.java 0.00% <0.00%> (-100.00%) ⬇️
... and 961 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@Jackie-Jiang Jackie-Jiang merged commit 716797f into apache:master Dec 1, 2022
@Jackie-Jiang Jackie-Jiang added ui UI related issue bugfix labels Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix ui UI related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants