Combine the read access for replication config #9849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snleee
force-pushed
the
clean-up-replication
branch
from
a15a690 to
291aee5
Compare
snleee
force-pushed
the
clean-up-replication
branch
2 times, most recently
from
17d555d to
db6366c
Compare
Codecov Report
@@ Coverage Diff @@
## master #9849 +/- ##
============================================
+ Coverage 70.36% 70.38% +0.01%
+ Complexity 5469 5013 -456
============================================
Files 1972 1972
Lines 105675 105687 +12
Branches 15989 15988 -1
============================================
+ Hits 74361 74386 +25
+ Misses 26116 26103 -13
Partials 5198 5198
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
snleee
force-pushed
the
clean-up-replication
branch
from
db6366c to
072ff53
Compare
Currently, we have a separate configuration for replication. Offline and HLC reads from `replication` and LLC reads from `replicasPerPartition`. This PR combines the read access for the replication config.
snleee
force-pushed
the
clean-up-replication
branch
from
072ff53 to
58e56da
Compare
Jackie-Jiang
approved these changes
Nov 23, 2022
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/TableConfig.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/TableConfig.java
Outdated
Show resolved
Hide resolved
...oller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java
Outdated
Show resolved
Hide resolved
...oller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java
Outdated
Show resolved
Hide resolved
...pi/src/main/java/org/apache/pinot/spi/config/table/SegmentsValidationAndRetentionConfig.java
Show resolved
Hide resolved
snleee
force-pushed
the
clean-up-replication
branch
from
14cde3e to
9aa1a7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have a separate configuration for replication. Offline and HLC reads from
replicationand LLC reads fromreplicasPerPartition. This PR combines the read access for the replication config.