[pinot-spark-connector] Fix empty data table handling in GRPC reader #9837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9837 +/- ##
=============================================
+ Coverage 34.69% 70.29% +35.60%
- Complexity 190 5000 +4810
=============================================
Files 1965 1965
Lines 105115 105115
Branches 15909 15909
=============================================
+ Hits 36474 73895 +37421
+ Misses 65542 26079 -39463
- Partials 3099 5141 +2042
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
approved these changes
Nov 22, 2022
|
Thanks @Jackie-Jiang ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where an exception is thrown when all of the data tables retuned in a Spark 'split' is empty.
When the Spark reader pushes down a filter which effectively reduces the returned data for all the segments to zero, GRPC data fetcher (
PinotGrpcServerDataFetcher) wrongly assumes that there was an error. This behavior was introduced when porting logic from the non-GRPC fetcher (PinotServerDataFetcher) where the assumption is correct. Http and GRPC interfaces differ in behavior where the HTTP interface will return empty instances of datatables whereas with GRPC you only get metadata.I'm updating the error handling to remove this assumption and record an error when there is actual exception thrown by the GRPC server.
bugfix