Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load startree index via segment reader interface #9828

Merged

Conversation

klsince
Copy link
Contributor

@klsince klsince commented Nov 17, 2022

Loading startree index via SegmentReader interface to decouple from File objects, as done for the other index types.

@klsince klsince force-pushed the load_starTree_index_via_segmentReader branch 2 times, most recently from 88b3e81 to 28c87ef Compare November 21, 2022 22:41
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2022

Codecov Report

Merging #9828 (e4c0360) into master (4d16027) will increase coverage by 32.73%.
The diff coverage is 48.57%.

@@              Coverage Diff              @@
##             master    #9828       +/-   ##
=============================================
+ Coverage     28.14%   60.87%   +32.73%     
- Complexity       53     5391     +5338     
=============================================
  Files          1970     1970               
  Lines        106081   106101       +20     
  Branches      16089    16093        +4     
=============================================
+ Hits          29858    64594    +34736     
+ Misses        73294    36740    -36554     
- Partials       2929     4767     +1838     
Flag Coverage Δ
integration1 ?
integration2 24.53% <0.00%> (-0.04%) ⬇️
unittests1 67.95% <48.57%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ent/local/segment/store/FilePerIndexDirectory.java 85.04% <0.00%> (+85.04%) ⬆️
.../pinot/segment/spi/store/ColumnIndexDirectory.java 28.57% <0.00%> (+28.57%) ⬆️
...ache/pinot/segment/spi/store/SegmentDirectory.java 45.45% <0.00%> (+45.45%) ⬆️
.../local/segment/store/SingleFileIndexDirectory.java 89.80% <75.00%> (+89.80%) ⬆️
...indexsegment/immutable/ImmutableSegmentLoader.java 85.57% <100.00%> (+85.57%) ⬆️
...t/local/segment/store/SegmentLocalFSDirectory.java 73.41% <100.00%> (+73.41%) ⬆️
...ocal/startree/v2/store/StarTreeIndexContainer.java 100.00% <100.00%> (+100.00%) ⬆️
...local/startree/v2/store/StarTreeIndexMapUtils.java 85.00% <100.00%> (+85.00%) ⬆️
...pinot/minion/exception/TaskCancelledException.java 0.00% <0.00%> (-100.00%) ⬇️
...ot/broker/requesthandler/BrokerRequestHandler.java 0.00% <0.00%> (-100.00%) ⬇️
... and 1237 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@klsince klsince force-pushed the load_starTree_index_via_segmentReader branch from 28c87ef to e4c0360 Compare December 7, 2022 00:53
Copy link
Contributor

@npawar npawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jackie-Jiang Jackie-Jiang merged commit d39b844 into apache:master Dec 7, 2022
@klsince klsince deleted the load_starTree_index_via_segmentReader branch December 7, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants