AdaptiveServerSelection: Update stats for servers that have not responded #9801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvivekiyer
force-pushed
the
fixAdssResponseStatsBug
branch
from
4e23486 to
5d294b5
Compare
Codecov Report
@@ Coverage Diff @@
## master #9801 +/- ##
============================================
- Coverage 70.15% 64.16% -5.99%
+ Complexity 5410 4975 -435
============================================
Files 1956 1908 -48
Lines 104975 102564 -2411
Branches 15892 15597 -295
============================================
- Hits 73641 65814 -7827
- Misses 26195 31975 +5780
+ Partials 5139 4775 -364
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| ServerResponse response = _responseMap.get(serverRoutingInstance); | ||
| response.receiveDataTable(dataTable, responseSize, deserializationTimeMs); | ||
|
|
||
| // Record query completion stats immediately after receiving the response from the server instead of waiting |
There was a problem hiding this comment.
Not sure I follow this change. Was this a bug ?
There was a problem hiding this comment.
Not a bug. I just consolidated all recordStatsUponResponseArrival into AsyncResponse instead of keeping it scattered all over. It makes sense to be here because if our response handling changes in the future, the author will be reminded to handle it.
There was a problem hiding this comment.
Got it. Thanks for clarifying.
siddharthteotia
approved these changes
Nov 15, 2022
siddharthteotia
pushed a commit
that referenced
this pull request
Nov 15, 2022
vvivekiyer
added a commit
to vvivekiyer/pinot
that referenced
this pull request
Nov 29, 2022
jackjlli
pushed a commit
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
label = bugfix
When broker routes a query to a server, but the server doesn't respond back within the timeout, the
numInFlightRequestsinServerRoutingStatsis never decremented. So, the algorithm now thinks that this server has outstanding requests and prefers this server lesser than the others.This PR fixes this bug. Added tests to confirm that
numInFlightRequestsis always zero - even if a server doesn't respond to a query.@siddharthteotia please review.