[multistage] add test for LiteralValueOperator #9796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9796 +/- ##
=============================================
- Coverage 70.17% 25.20% -44.98%
+ Complexity 5407 44 -5363
=============================================
Files 1956 1944 -12
Lines 104975 104622 -353
Branches 15892 15854 -38
=============================================
- Hits 73669 26369 -47300
- Misses 26157 75546 +49389
+ Partials 5149 2707 -2442
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
siddharthteotia
approved these changes
Nov 14, 2022
walterddr
reviewed
Nov 14, 2022
| // Then: | ||
| Assert.assertEquals(transferableBlock.getContainer().get(0), new Object[]{"foo", 1}); | ||
| Assert.assertEquals(transferableBlock.getContainer().get(1), new Object[]{"bar", 2}); | ||
| Assert.assertTrue(operator.nextBlock().isEndOfStreamBlock(), "Expected EOS after reading two rows"); |
There was a problem hiding this comment.
can you also add a test for literals that are empty?
There was a problem hiding this comment.
added, but how can you create an empty literal in first place (in SQL)?
There was a problem hiding this comment.
SELECT col1 FROM tbl WHERE col2 BETWEEN 0 AND -1 will generate an empty literal value node with schema of col1 and 0 rows.
walterddr
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super quick and easy test :)