[multistage][test] add from expression queries #9782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterddr
force-pushed
the
pr_add_join_tests
branch
from
680d921 to
4b87a67
Compare
Codecov Report
@@ Coverage Diff @@
## master #9782 +/- ##
=============================================
+ Coverage 24.55% 70.22% +45.67%
- Complexity 53 4920 +4867
=============================================
Files 1952 1964 +12
Lines 104676 105029 +353
Branches 15856 15894 +38
=============================================
+ Hits 25700 73755 +48055
+ Misses 76347 26137 -50210
- Partials 2629 5137 +2508
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
agavra
approved these changes
Nov 14, 2022
walterddr
force-pushed
the
pr_add_join_tests
branch
from
dff6aae to
09969c1
Compare
walterddr
changed the title
walterddr
commented
Nov 15, 2022
...rc/main/java/org/apache/pinot/query/runtime/operator/LeafStageTransferableBlockOperator.java
Outdated
Show resolved
Hide resolved
walterddr
commented
Nov 15, 2022
...ry-runtime/src/main/java/org/apache/pinot/query/runtime/operator/operands/FilterOperand.java
Show resolved
Hide resolved
walterddr
commented
Nov 15, 2022
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryConfig.java
Outdated
Show resolved
Hide resolved
agavra
reviewed
Nov 16, 2022
walterddr
force-pushed
the
pr_add_join_tests
branch
2 times, most recently
from
431397d to
8cefcc3
Compare
walterddr
commented
Nov 16, 2022
61yao
reviewed
Nov 16, 2022
| } | ||
| ] | ||
| }, | ||
| "extended_join_features": { |
There was a problem hiding this comment.
Can we have a test where left or right table is empty?
Can we add join with using condition and where exists?
There was a problem hiding this comment.
- added several where clauses that matches nothing on left or right table already. but yes I can add several explicit joins where left or right table is entirely empty
- where exists is not supported.
There was a problem hiding this comment.
Hmm...last time I tested where exists, it was supported. Let me double check
There was a problem hiding this comment.
where exists is also added in #9817 and ignored.
There was a problem hiding this comment.
added empty table explicit tests
walterddr
changed the title
walterddr
force-pushed
the
pr_add_join_tests
branch
from
c2f96f5 to
42bf2b0
Compare
walterddr
commented
Nov 17, 2022
pinot-query-runtime/src/test/resources/queries/FromExpressions.json
Outdated
Show resolved
Hide resolved
siddharthteotia
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from PostgresQL doc section 7.2.1
mostly testing the join features
depend on #9807