Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: show an option to reload the segments during edit schema #9762

Merged
merged 4 commits into from
Nov 14, 2022

Conversation

jayeshchoudhary
Copy link
Contributor

@jayeshchoudhary jayeshchoudhary commented Nov 8, 2022

What does this PR do?

show an option to reload the segments during edit schema

Issue

  • Sometimes schema update require segments to be reloaded for updated schema to become effective.
  • Backend accepts a query param reload=true flag in the update schema API that indicates whether to start reload of the table or not
  • Right now UI doesn't have the option to pass reload option when updating schema.

Description

  • The user should be given a choice on whether a table reload is needed or not.
  • Add a checkbox (unchecked by default) that will give an option for user to send reload flag when edting schema.

UI Screenshots

segment-reload.mp4
  • added tooltip for more clarity

image

Edit 1 - change checkbox label to "Reload all segments"

image

@jayeshchoudhary jayeshchoudhary changed the title UI: show option to reload the segments during edit schema UI: show an option to reload the segments during edit schema Nov 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2022

Codecov Report

Merging #9762 (f0074c5) into master (818f59a) will increase coverage by 0.14%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9762      +/-   ##
============================================
+ Coverage     63.97%   64.11%   +0.14%     
- Complexity     4953     5385     +432     
============================================
  Files          1901     1903       +2     
  Lines        102407   102554     +147     
  Branches      15584    15604      +20     
============================================
+ Hits          65510    65749     +239     
+ Misses        32113    32025      -88     
+ Partials       4784     4780       -4     
Flag Coverage Δ
unittests1 67.76% <ø> (+0.20%) ⬆️
unittests2 15.68% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntroller/helix/core/minion/TaskMetricsEmitter.java 18.60% <0.00%> (-16.28%) ⬇️
.../index/loader/invertedindex/RangeIndexHandler.java 54.78% <0.00%> (-9.57%) ⬇️
...va/org/apache/pinot/query/runtime/QueryRunner.java 74.33% <0.00%> (-7.22%) ⬇️
...ionaryBasedMultiColumnDistinctOrderByExecutor.java 94.44% <0.00%> (-5.56%) ⬇️
...not/broker/broker/helix/ClusterChangeMediator.java 75.26% <0.00%> (-5.38%) ⬇️
...rg/apache/pinot/common/datablock/RowDataBlock.java 62.50% <0.00%> (-4.17%) ⬇️
...t/controller/util/ServerSegmentMetadataReader.java 31.13% <0.00%> (-2.89%) ⬇️
...e/pinot/common/request/context/LiteralContext.java 57.89% <0.00%> (-2.64%) ⬇️
.../java/org/apache/pinot/spi/data/TimeFieldSpec.java 88.63% <0.00%> (-2.28%) ⬇️
...g/apache/pinot/common/datablock/BaseDataBlock.java 75.31% <0.00%> (-2.13%) ⬇️
... and 45 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jayeshchoudhary
Copy link
Contributor Author

@navina @npawar @joshigaurava

@navina
Copy link
Contributor

navina commented Nov 12, 2022

@jayeshchoudhary It will be clear if the checkbox reads "Reload all segments", instead of "Reload Segments"

@npawar npawar merged commit df44d67 into apache:master Nov 14, 2022
@Jackie-Jiang Jackie-Jiang added the ui UI related issue label Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui UI related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants