Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bubble up error messages from broker #9754

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Conversation

agavra
Copy link
Contributor

@agavra agavra commented Nov 8, 2022

This PR improves error message handling on the broker and ensures that root causes are returned to the user. There's probably a lot of additional work to be done to make sure that the response is improved for all different types of error messages, but this is an improvement over the status quo.

cc @npawar

Local Testing:
Screen Shot 2022-11-07 at 5 10 40 PM

@codecov-commenter
Copy link

Codecov Report

Merging #9754 (b1662bf) into master (2f640ff) will decrease coverage by 1.57%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master    #9754      +/-   ##
============================================
- Coverage     70.08%   68.50%   -1.58%     
+ Complexity     4980     4967      -13     
============================================
  Files          1951     1953       +2     
  Lines        104561   104801     +240     
  Branches      15836    15871      +35     
============================================
- Hits          73279    71794    -1485     
- Misses        26155    27889    +1734     
+ Partials       5127     5118       -9     
Flag Coverage Δ
integration1 25.30% <66.66%> (-0.14%) ⬇️
integration2 ?
unittests1 67.57% <ø> (+0.01%) ⬆️
unittests2 15.64% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/controller/api/resources/PinotQueryResource.java 11.18% <0.00%> (-43.04%) ⬇️
...pinot/broker/api/resources/PinotClientRequest.java 45.71% <100.00%> (+2.43%) ⬆️
...pinot/core/data/manager/realtime/TimerService.java 0.00% <0.00%> (-100.00%) ⬇️
...t/core/plan/StreamingInstanceResponsePlanNode.java 0.00% <0.00%> (-100.00%) ⬇️
...ore/operator/streaming/StreamingResponseUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...server/starter/helix/SegmentReloadStatusValue.java 0.00% <0.00%> (-100.00%) ⬇️
...ager/realtime/PeerSchemeSplitSegmentCommitter.java 0.00% <0.00%> (-100.00%) ⬇️
...urces/ServerReloadControllerJobStatusResponse.java 0.00% <0.00%> (-100.00%) ⬇️
...he/pinot/common/utils/grpc/GrpcRequestBuilder.java 0.00% <0.00%> (-90.91%) ⬇️
...ator/streaming/StreamingSelectionOnlyOperator.java 0.00% <0.00%> (-90.00%) ⬇️
... and 164 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@npawar npawar merged commit 3252a62 into apache:master Nov 9, 2022
Copy link
Contributor

@walterddr walterddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious why is this example an exception? this seems like a bug to me. was it thrown cuz the int/double matching issue; or the agg field is not escaped?

@agavra agavra deleted the error_handling branch November 10, 2022 16:33
@agavra
Copy link
Contributor Author

agavra commented Nov 10, 2022

@walterddr I agree with you, but that's orthogonal to this PR 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants