Use ideal state as source of truth for segment existence #9735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9735 +/- ##
============================================
- Coverage 70.04% 68.43% -1.62%
- Complexity 4907 4972 +65
============================================
Files 1951 1951
Lines 104512 104515 +3
Branches 15824 15827 +3
============================================
- Hits 73210 71525 -1685
- Misses 26175 27892 +1717
+ Partials 5127 5098 -29
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
force-pushed
the
fix_get_segments
branch
from
3bb60f6 to
67fb19e
Compare
walterddr
approved these changes
Nov 5, 2022
| @@ -730,22 +730,29 @@ public String getActualTableName(String tableName) { | |||
| */ | |||
|
|
|||
| /** | |||
| * Returns the segments for the given table. | |||
| * Returns the segments for the given table from the ideal state. | |||
| * | |||
| * @param tableNameWithType Table name with type suffix | |||
| * @param shouldExcludeReplacedSegments whether to return the list of segments that doesn't contain replaced segments. | |||
| * @return List of segment names | |||
| */ | |||
| public List<String> getSegmentsFor(String tableNameWithType, boolean shouldExcludeReplacedSegments) { | |||
There was a problem hiding this comment.
getSegmentsFor is originally also used in SegmentRelocator and RetentionManager are those 2 usage both IS as well?
There was a problem hiding this comment.
Yes. Checked all the usage of them and moved the ones to clean up the orphan segments (e.g. when deleting the table or all segments) to use getSegmentsFromPropertyStore()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting a segment, we delete the segment from ideal state synchronously, then use a separate thread to delete the segment from property store and deep store asynchronously. This could cause inconsistency between ideal state and segments in the property store, and we should always use ideal state as the source of truth for the segments because that is what Helix is following. The segment ZK metadata from the property store can be used to track the orphan segments that are not cleaned up property.