Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the server admin endpoint cache to reflect the config changes #9734

Merged
merged 1 commit into from
Nov 5, 2022

Conversation

Jackie-Jiang
Copy link
Contributor

Currently the server admin endpoints are cached within the controller, but there is no watcher on the instance config changes, which causes the admin endpoint change not reflected.
This PR adds the instance config change listener to the controller to invalidate the cache when there is changes to the instance config.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Merging #9734 (3ff379b) into master (5988ff3) will increase coverage by 44.63%.
The diff coverage is 57.14%.

@@              Coverage Diff              @@
##             master    #9734       +/-   ##
=============================================
+ Coverage     25.38%   70.02%   +44.63%     
- Complexity       44     4905     +4861     
=============================================
  Files          1938     1951       +13     
  Lines        104138   104519      +381     
  Branches      15781    15826       +45     
=============================================
+ Hits          26440    73188    +46748     
+ Misses        75000    26196    -48804     
- Partials       2698     5135     +2437     
Flag Coverage Δ
integration1 25.39% <40.47%> (+<0.01%) ⬆️
integration2 24.62% <45.23%> (?)
unittests1 67.53% <ø> (?)
unittests2 15.69% <35.71%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntroller/helix/core/PinotHelixResourceManager.java 71.70% <57.14%> (+32.48%) ⬆️
...data/manager/realtime/DefaultSegmentCommitter.java 0.00% <0.00%> (-80.00%) ⬇️
...er/api/resources/LLCSegmentCompletionHandlers.java 43.56% <0.00%> (-18.82%) ⬇️
...altime/ServerSegmentCompletionProtocolHandler.java 51.88% <0.00%> (-6.61%) ⬇️
...ache/pinot/core/operator/docidsets/OrDocIdSet.java 86.36% <0.00%> (-2.28%) ⬇️
...pache/pinot/core/query/utils/idset/EmptyIdSet.java 25.00% <0.00%> (ø)
...mmon/request/context/predicate/NotEqPredicate.java 76.92% <0.00%> (ø)
...anager/realtime/SegmentBuildTimeLeaseExtender.java 63.23% <0.00%> (ø)
...apache/pinot/ingestion/jobs/SegmentUriPushJob.java 0.00% <0.00%> (ø)
...ker/api/resources/BrokerEchoWithAutoDiscovery.java 0.00% <0.00%> (ø)
... and 1413 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants