[hotfix]groovy class cache leak #9716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
walterddr
commented
Nov 3, 2022
Comment on lines
46
to
47
| String templateRendered = GROOVY_TEMPLATE_ENGINE.createTemplate(template).make(contextMap).toString(); | ||
| GROOVY_SHELL.getClassLoader().clearCache(); |
There was a problem hiding this comment.
this means the cache will not kick in if we try to re-register the same template. but i don't think this will be created on a per-row basis
jackjlli
approved these changes
Nov 3, 2022
Jackie-Jiang
approved these changes
Nov 3, 2022
pinot-spi/src/main/java/org/apache/pinot/spi/utils/GroovyTemplateUtils.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Xiaotian (Jackie) Jiang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #9716 +/- ##
=============================================
+ Coverage 28.13% 63.01% +34.88%
- Complexity 53 4758 +4705
=============================================
Files 1936 1938 +2
Lines 103927 104133 +206
Branches 15770 15780 +10
=============================================
+ Hits 29235 65619 +36384
+ Misses 71832 33643 -38189
- Partials 2860 4871 +2011
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
classloader cache is not cleared.
before:
after:
