Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the setup for ControllerTest shared cluster #9704

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

Jackie-Jiang
Copy link
Contributor

Currently the ControllerTest shared cluster setup mixes the single tenant and multi-tenant setup, which can cause unexpected behavior and is hard to debug

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2022

Codecov Report

Merging #9704 (11cdabc) into master (694999c) will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9704      +/-   ##
============================================
+ Coverage     69.91%   69.98%   +0.07%     
+ Complexity     5323     5322       -1     
============================================
  Files          1950     1950              
  Lines        104338   104338              
  Branches      15804    15804              
============================================
+ Hits          72946    73021      +75     
+ Misses        26270    26186      -84     
- Partials       5122     5131       +9     
Flag Coverage Δ
integration1 25.41% <ø> (+<0.01%) ⬆️
integration2 24.62% <ø> (+0.02%) ⬆️
unittests1 67.42% <ø> (-0.01%) ⬇️
unittests2 15.71% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../helix/core/minion/MinionInstancesCleanupTask.java 77.27% <0.00%> (-4.55%) ⬇️
...ct/raw/RawIntSingleColumnDistinctOnlyExecutor.java 81.48% <0.00%> (-3.71%) ⬇️
...gregation/function/StUnionAggregationFunction.java 73.52% <0.00%> (-2.95%) ⬇️
...inot/core/operator/filter/FilterOperatorUtils.java 87.50% <0.00%> (-2.50%) ⬇️
...core/query/pruner/SelectionQuerySegmentPruner.java 85.88% <0.00%> (-2.36%) ⬇️
...e/pinot/controller/helix/SegmentStatusChecker.java 87.50% <0.00%> (-1.71%) ⬇️
...ery/optimizer/filter/MergeEqInFilterOptimizer.java 92.59% <0.00%> (-1.24%) ⬇️
...perator/filter/SortedIndexBasedFilterOperator.java 85.71% <0.00%> (-0.96%) ⬇️
...core/startree/operator/StarTreeFilterOperator.java 88.07% <0.00%> (-0.67%) ⬇️
...a/org/apache/pinot/core/common/DataBlockCache.java 88.81% <0.00%> (-0.63%) ⬇️
... and 22 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jackie-Jiang Jackie-Jiang force-pushed the fix_controller_test_setup branch from 8624ba5 to 11cdabc Compare November 1, 2022 22:42
@Jackie-Jiang Jackie-Jiang merged commit a541396 into apache:master Nov 2, 2022
@Jackie-Jiang Jackie-Jiang deleted the fix_controller_test_setup branch November 2, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants